fix(app): disallow non .py or .json protocol upload #16076
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Analagous to our handling of non-.json custom labware upload, we want to disallow upload of .py or .json files on Desktop. Expected behavior is to check the filename extension of the prospective uploaded file (erring on the side of lenient acceptance), and close the slideout and make error toast if the extension is not .py or .json.
Closes RQA-2959
Test Plan and Hands on Testing
With other protocols:
Screen.Recording.2024-08-20.at.4.03.34.PM.mov
With no other protocols:
Screen.Recording.2024-08-20.at.4.02.48.PM.mov
Changelog
Review requests
isValidProtocolFileName
, I can update.Risk assessment
Low-medium. We want to allow any attempted upload within reasonable file type matching